[PATCH] D77708: [lit] Improve naming of test result categories

[Julian Lettner via Phabricator via llvm-commits]

yln added a comment.

I am happy to hear that other people also value improving consistency!  :)

In D77708#1969638 <https://reviews.llvm.org/D77708#1969638>, @rnk wrote:

> I kind of like "Passes", "Failures", "Expected Failures" better than Pass-*ing* Fail-*ing* etc. But I do think we can drop "Expected" from "Expected Passes".
>
> To be consistent, you could change the text "Failing Tests (1):" to "Test Failures (1):"


I feel the same about "Passes"/"Failures" vs. "Passing"/"Failing".  I can't even give a good reason other than that to me it sounds better.  Maybe because I am just used to it by now.
The issue with the old naming is that some labels are nouns and some are adjectives. If everything follows the same scheme we can print the label in the summary and use "<label> Tests" as the group headings.  How about "Passed"/"Failed"?

In D77708#1969689 <https://reviews.llvm.org/D77708#1969689>, @jdenny wrote:

> In D77708#1969638 <https://reviews.llvm.org/D77708#1969638>, @rnk wrote:
>
> > I kind of like "Passes", "Failures", "Expected Failures" better than Pass-*ing* Fail-*ing* etc. But I do think we can drop "Expected" from "Expected Passes".
>
>
> I like "Expected Passes" to clarify it does not include unexpected passes.  This would mostly be helpful for developers used to test harnesses without an XFAIL concept.


I think for new developers and people who can be blissfully ignorant of lit's `XFAIL`/`XPASS` the following is better

  Passing: 3
  Failing: 1

than this:

  Expected Passes    : 3
  Unexpected Failures: 1

For devs who need to care the "normal" is short and the "odd" is long and ugly to draw attention:

  Expectedly Failing:   1
  Unexpectedly Passing: 1



In D77708#1969436 <https://reviews.llvm.org/D77708#1969436>, @ldionne wrote:

> Did you check whether other parts of LLVM had tests relying on this output? Otherwise, LGTM.


I will run `ninja check-all` and grep for the old names before landing this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77708/new/

https://reviews.llvm.org/D77708