[PATCH] D77708: [lit] Improve naming of test result categories

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 8 09:12:50 PDT 2020


jdenny added a comment.

In D77708#1969638 <https://reviews.llvm.org/D77708#1969638>, @rnk wrote:

> I kind of like "Passes", "Failures", "Expected Failures" better than Pass-*ing* Fail-*ing* etc. But I do think we can drop "Expected" from "Expected Passes".


I like "Expected Passes" to clarify it does not include unexpected passes.  This would mostly be helpful for developers used to test harnesses without an XFAIL concept.

> To be consistent, you could change the text "Failing Tests (1):" to "Test Failures (1):"

I do like this kind of improved consistency.

By the way, are there any bots or other runners that grep for the current keywords when presenting results?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77708/new/

https://reviews.llvm.org/D77708





More information about the llvm-commits mailing list