[PATCH] D72194: [MC][ELF] Ensure that mergeable globals with an explicit section are assigned to SHF_MERGE sections with compatible entsizes

Wed Apr 8 14:41:06 PDT 2020

MaskRay added a comment.

In D72194#1970292 <https://reviews.llvm.org/D72194#1970292>, @bd1976llvm wrote:

> I would like to keep this as part of this patch.
>
> In D72194#1969772 <https://reviews.llvm.org/D72194#1969772>, @MaskRay wrote:
>
> > Thanks! `clang/test/CodeGen/cfstring-elf-sections-x86_64.c` needs to be deleted as well.
>
>
> I don't think that I can remove `clang/test/CodeGen/cfstring-elf-sections-x86_64.c` because if I do then I can't commit this as it will break that Clang test?

Ah, yes. Thanks for the clarification.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72194/new/

https://reviews.llvm.org/D72194