[PATCH] D72194: [MC][ELF] Ensure that mergeable globals with an explicit section are assigned to SHF_MERGE sections with compatible entsizes

ben via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 8 14:08:32 PDT 2020


bd1976llvm added a comment.

I would like to keep this as part of this patch.

In D72194#1969772 <https://reviews.llvm.org/D72194#1969772>, @MaskRay wrote:

> Thanks! `clang/test/CodeGen/cfstring-elf-sections-x86_64.c` needs to be deleted as well.


I don't think that I can remove `clang/test/CodeGen/cfstring-elf-sections-x86_64.c` because if I do then I can't commit this as it will break that Clang test?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72194/new/

https://reviews.llvm.org/D72194





More information about the llvm-commits mailing list