[PATCH] D77640: [llvm-objdump] Fix unstable disassembly output for sections with same address

Wed Apr 8 02:39:59 PDT 2020

jhenderson marked 2 inline comments as done.
jhenderson added inline comments.

================
Comment at: llvm/test/tools/llvm-objdump/X86/disassemble-same-section-addr.test:1
+## This test shows that llvm-objdump can handle sections with the same address
+## when symbols in those sections are referenced. In the past, the section
----------------
MaskRay wrote:
> More of a question: shall we place generic disassembly behavior to `test/tools/llvm-objdump/ELF/` ?
> 
> I know that we mostly place disassembly tests under `X86/`, so this patch is consistent with the current practice and does not need a change.
I noticed that the llvm-objdump testing is a bit of a mess, because there are two unrelated axes of testing - targets and file formats. Consequently, we have both `ELF` and `X86` folders independently of each other. It's also not always clear to me which axis is important to the test. In this case, I think the answer is actually "neither" (the principle is target and format agnostic, I believe) and it's only in the X86 folder for convenience, due to the need for an X86 disassembler.

As to what we should do elsewhere, maybe we need a "Generic" folder alongside ELF etc, and in that folder, put the X86 etc folders as required? I don't know really.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77640/new/

https://reviews.llvm.org/D77640