[PATCH] D77640: [llvm-objdump] Fix unstable disassembly output for sections with same address

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.

Thanks.

Please mention that the non-determinism comes from `SectionRef::operator<(const SectionRef &) const` comparing the pointers.



================
Comment at: llvm/test/tools/llvm-objdump/X86/disassemble-same-section-addr.test:1
+## This test shows that llvm-objdump can handle sections with the same address
+## when symbols in those sections are referenced. In the past, the section
----------------
More of a question: shall we place generic disassembly behavior to `test/tools/llvm-objdump/ELF/` ?

I know that we mostly place disassembly tests under `X86/`, so this patch is consistent with the current practice and does not need a change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77640/new/

https://reviews.llvm.org/D77640