[PATCH] D77649: [mlir][DRR] Add location directive

Lei Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 7 14:10:48 PDT 2020


antiagainst added a comment.

Cool! Thanks for pushing forward on this! :)



================
Comment at: mlir/docs/DeclarativeRewrites.md:671
+
+```tablgen
+(location $symbol0, $symbol1, ...)
----------------
typo: tablegen 


================
Comment at: mlir/include/mlir/IR/OpBase.td:2168
+// op. This directive must be used as the last argument to the op creation
+// DAG construct. The arguments to location must be previously captured symbol.
+def location;
----------------
symbols


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77649/new/

https://reviews.llvm.org/D77649





More information about the llvm-commits mailing list