[PATCH] D77639: [DebugInfo][NFC] Early-exit when analysing for single-location variables

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1485
+  // candidate for being validThroughout.
+  if (RangeEnd != nullptr && !DbgValue->getOperand(0).isImm())
+    return false;
----------------
dstenb wrote:
> Nit: It might be preferred to use `!RangeEnd` here since the rest of the code in this function does nullptr checks like that.
You probably mean `RangeEnd`? 
I also think that is better.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1498
+  const MachineInstr *LScopeEnd = LSRange.back().second;
+  if (RangeEnd && LScopeEnd->getParent() != MBB)
+    return false;
----------------
like here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77639/new/

https://reviews.llvm.org/D77639