[PATCH] D77639: [DebugInfo][NFC] Early-exit when analysing for single-location variables

[David Stenberg via Phabricator via llvm-commits]

dstenb accepted this revision.
dstenb added a comment.
This revision is now accepted and ready to land.

Two minor nits, but otherwise this looks good to me. Thanks!

(It would be interesting to revisit this "Single, constant DBG_VALUEs" behavior sometime in the future, but I don't expect you do that just because you improved the performance of the existing behavior.)



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1485
+  // candidate for being validThroughout.
+  if (RangeEnd != nullptr && !DbgValue->getOperand(0).isImm())
+    return false;
----------------
Nit: It might be preferred to use `!RangeEnd` here since the rest of the code in this function does nullptr checks like that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77639/new/

https://reviews.llvm.org/D77639