[PATCH] D77624: [PowerPC] Update alignment for ReuseLoadInfo in LowerFP_TO_INTForReuse

[Qing Shan Zhang via Phabricator via llvm-commits]

steven.zhang added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7945
   RLI.MPI = MPI;
+  RLI.Alignment = Alignment;
 }
----------------
lkail wrote:
> steven.zhang wrote:
> > You are setting the RLI.Alignment to uninitialized value if it is not i32Stack.
> The default constructor of `Align` will set it to 1. This is consistent with `Chain = DAG.getStore(DAG.getEntryNode(), dl, Tmp, FIPtr, MPI);` which also will have alignment of 1 for the store. I don't have deep insight of if it's correct for the `Chain` to have alignment of 1 yet.
You shouldn't have the assumption of the value of the default arguments of the Alignment and the getStore(), as they can be changed. You should specify the explicit initial value of the Alignment. (i.e. Align Alignment(1)).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77624/new/

https://reviews.llvm.org/D77624