[PATCH] D77624: [PowerPC] Update alignment for ReuseLoadInfo in LowerFP_TO_INTForReuse

Kai Luo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 6 20:44:08 PDT 2020


lkail marked an inline comment as done.
lkail added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7945
   RLI.MPI = MPI;
+  RLI.Alignment = Alignment;
 }
----------------
steven.zhang wrote:
> You are setting the RLI.Alignment to uninitialized value if it is not i32Stack.
The default constructor of `Align` will set it to 1. This is consistent with `Chain = DAG.getStore(DAG.getEntryNode(), dl, Tmp, FIPtr, MPI);` which also will have alignment of 1 for the store. I don't have deep insight of if it's correct for the `Chain` to have alignment of 1 yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77624/new/

https://reviews.llvm.org/D77624





More information about the llvm-commits mailing list