[PATCH] D77308: [DWARF] Detect extraction errors in DWARFFormValue::extractValue

Mon Apr 6 11:25:40 PDT 2020

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

In D77308#1963790 <https://reviews.llvm.org/D77308#1963790>, @labath wrote:

> In D77308#1958553 <https://reviews.llvm.org/D77308#1958553>, @aprantl wrote:
>
> > I guess this might be unit-testable by supplying too-short DataExtractors?
>
>
> That is what the code DWARFFormValueTest is doing. Maybe it's somewhat over-engineered (I would have just written a sequence of EXPECTS, instead of instantiating a separate test for each form), but I tried to follow the style of the other tests in that file.
>
> @dblaikie: Is that what you had in mind, or were you expecting to see some higher-level tests?

Nah, that looks good to me - I think I was probably just going change blind with all the reviews.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77308/new/

https://reviews.llvm.org/D77308