[PATCH] D77308: [DWARF] Detect extraction errors in DWARFFormValue::extractValue
Pavel Labath via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 6 06:27:44 PDT 2020
labath added a comment.
In D77308#1958553 <https://reviews.llvm.org/D77308#1958553>, @aprantl wrote:
> I guess this might be unit-testable by supplying too-short DataExtractors?
That is what the code DWARFFormValueTest is doing. Maybe it's somewhat over-engineered (I would have just written a sequence of EXPECTS, instead of instantiating a separate test for each form), but I tried to follow the style of the other tests in that file.
@dblaikie: Is that what you had in mind, or were you expecting to see some higher-level tests?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77308/new/
https://reviews.llvm.org/D77308
More information about the llvm-commits
mailing list