[PATCH] D77557: [DWARFDebugLine] Use truncating data extractors for prologue parsing

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 6 08:38:48 PDT 2020


probinson added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugLine.h:132
     void dump(raw_ostream &OS, DIDumpOptions DumpOptions) const;
-    Error parse(const DWARFDataExtractor &DebugLineData, uint64_t *OffsetPtr,
+    Error parse(DWARFDataExtractor Data, uint64_t *OffsetPtr,
                 function_ref<void(Error)> RecoverableErrorHandler,
----------------
The truncating constructor takes a `const DWARFDataExtractor&` so I don't understand why this parameter had to change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77557/new/

https://reviews.llvm.org/D77557





More information about the llvm-commits mailing list