[PATCH] D77557: [DWARFDebugLine] Use truncating data extractors for prologue parsing

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 6 08:06:23 PDT 2020


labath created this revision.
labath added reviewers: jhenderson, dblaikie, probinson, ikudrin.
Herald added subscribers: MaskRay, hiraditya.
Herald added a project: LLVM.
labath added parent revisions: D77308: [DWARF] Detect extraction errors in DWARFFormValue::extractValue, D77556: [DWARFDataExtractor] Add a "truncating" constructor, D77555: [DWARFDebugLine] Check for errors when parsing v2 file/dir lists, D77554: [DWARFDebugLine] Check for (EOF) errors when parsing v5 content descriptors.
Herald added a subscriber: ormris.

This makes the code easier to reason about, as it will behave the same
way regardless of whether there is any more data coming after the
presumed end of the prologue.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D77557

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugLine.h
  llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
  llvm/test/tools/llvm-dwarfdump/X86/Inputs/debug_line_malformed.s
  llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test
  llvm/test/tools/llvm-dwarfdump/X86/debug_line_short_prologue.s
  llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77557.255346.patch
Type: text/x-patch
Size: 21549 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200406/6df6520a/attachment-0001.bin>


More information about the llvm-commits mailing list