[PATCH] D75566: [Matrix] Add initial tiling for load/multiply/store chains.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 5 14:25:53 PDT 2020


fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:1011-1013
+    // Check if the store begins before the end of the load location. If the
+    // condition holds, they alias, otherwise they are guaranteed to not
+    // overlap.
----------------
anemet wrote:
> Are you being overly conservative here?  If the end of the store is before the beginning of the load they still don't alias.  
Yes, I think but the previous condition (line 1008) ensures that the load begins before the end of the store if we check the condition here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75566/new/

https://reviews.llvm.org/D75566





More information about the llvm-commits mailing list