[PATCH] D75566: [Matrix] Add initial tiling for load/multiply/store chains.

[Adam Nemet via Phabricator via llvm-commits]

anemet requested changes to this revision.
anemet added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:59
+    TileSize("fuse-matrix-tile-size", cl::init(4), cl::Hidden,
+             cl::desc("Tile size for matrix instruction fusion."));
+static cl::opt<bool> ForceFusion(
----------------
Say it's square-shaped.


================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:1011-1013
+    // Check if the store begins before the end of the load location. If the
+    // condition holds, they alias, otherwise they are guaranteed to not
+    // overlap.
----------------
Are you being overly conservative here?  If the end of the store is before the beginning of the load they still don't alias.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75566/new/

https://reviews.llvm.org/D75566