[PATCH] D49116: Setup clang-format as an Arcanist linter

[Stella Laurenzo via Phabricator via llvm-commits]

stellaraccident added a comment.

In D49116#1158298 <https://reviews.llvm.org/D49116#1158298>, @starsid wrote:

> In D49116#1158292 <https://reviews.llvm.org/D49116#1158292>, @dberris wrote:
>
> > One concern here would be whether this would even work on Windows, and whether it might make more sense to use a more portable scripting language to do it instead (say, Python). I don't use Windows so I'll let someone else who does (and uses Arcanist as well) to chime in as to whether this is going to be a problem.
>
>
> I don't have a Windows machine to test, but maybe someone can port the bash script to python, while testing it on Windows. I don't mind if we don't commit this revision now, but someone takes over, and changes it to work on Windows.


I use arcanist on Windows via msys2, and out of the box, this does indeed fail to launch clang-format.sh (giving the normal error about Windows not knowing how to execute that kind of file -- sorry, the specific shell history is gone now). I've been passing --nolint and typing in a warning every time, which is a bit annoying. I suspect that since arcanist is a native windows command, it is trying to launch the script "natively", whereas if arcanist is installed through some other means (cygwin? msys2 package?), this might have a better time.

The next time I do some arcanist patches work on Windows, I'll see if I can fiddle with it. But in general, +1 on python vs bash as likely being more portable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49116/new/

https://reviews.llvm.org/D49116