[PATCH] D49116: Setup clang-format as an Arcanist linter

[Siddhartha Bagaria via Phabricator via llvm-commits]

starsid marked 2 inline comments as done.
starsid added inline comments.


================
Comment at: utils/arcanist/clang-format.sh:13
+
+if ! hash clang-format-diff >/dev/null; then
+  # advice severity level is completely non-disruptive.
----------------
mehdi_amini wrote:
> starsid wrote:
> > mehdi_amini wrote:
> > > I have clang-format installed, I can run `git clang-format` as well, but I don't have a `clang-format-diff` executable and I don't even know how to get it.
> > > 
> > > However I see `clang/tools/clang-format/clang-format-diff.py` in the repo, can we call this directly?
> > Sure, `clang-format-diff` was a suggestion from the last code review.  I don't think `git-clang-format` was available at the time. Please feel free to send an update to people to get it approved and landed.
> Do you mind addressing all these now? You just landed it I'd expect you to be in position to do this.
Sent {D77363}.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49116/new/

https://reviews.llvm.org/D49116