[PATCH] D77370: [libunwind] Add LIBUNWIND_ENABLE_PIC

Fri Apr 3 12:57:49 PDT 2020

ldionne added a comment.

In D77370#1960452 <https://reviews.llvm.org/D77370#1960452>, @tambre wrote:

> In D77370#1960387 <https://reviews.llvm.org/D77370#1960387>, @compnerd wrote:
>
> > I think that this really was an oversight, and that we should default to PIC builds, at least for shared libraries.
>
>
> Would two flags `LIBUNWIND_ENABLE_SHARED_PIC` and `LIBUNWIND_ENABLE_STATIC_PIC` sound good to you? Then we could default shared to `ON`, but static to `OFF`.
>  Enabling PIC in static builds is something I need.

Can't you just enable it globally for libunwind and then only use the static library? The creation of several `MEOW_SHARED` and `MEOW_STATIC` options makes the build system a lot more complicated than it should be.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77370/new/

https://reviews.llvm.org/D77370