[PATCH] D77370: [libunwind] Add LIBUNWIND_ENABLE_PIC
Louis Dionne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 3 12:30:30 PDT 2020
ldionne added a comment.
In D77370#1960387 <https://reviews.llvm.org/D77370#1960387>, @compnerd wrote:
> I think that this really was an oversight, and that we should default to PIC builds, at least for shared libraries.
I agree the default should probably be to enable PIC, but FWIW some vendors do build with PIC disabled. For example, we build with PIC disabled because we link everything in a shared cache on iOS. I'm fine if we change the default, I'll just start specifying `LIBUNWIND_ENABLE_PIC=OFF`. I would just pick whatever is consistent with the other runtime libraries.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77370/new/
https://reviews.llvm.org/D77370
More information about the llvm-commits
mailing list