[PATCH] D77227: [RFC][FileCheck] Require colon immediately after CHECK directives

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 3 11:53:39 PDT 2020


probinson added a comment.

In D77227#1959961 <https://reviews.llvm.org/D77227#1959961>, @probinson wrote:

> Grepping for `\bCHECK(NEXT|DAG|SAME|NOT):` in llvm/test and clang/test (that is, a directive missing the hyphen separator) turns up nothing.  Are gotchas 4 and 5 really something we should worry about?


After Joel pointed out my grep-failure in a previous case, I revisited this with proper backslash quoting.

`CHECK_[suffix]` (underscore not hyphen) occurs 25 times in llvm/test and 15 times in clang/test.
`CHECK[suffix]` (missing hyphen) occurs 1 time in llvm/test and 0 times in clang/test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77227/new/

https://reviews.llvm.org/D77227





More information about the llvm-commits mailing list