[PATCH] D77227: [RFC][FileCheck] Require colon immediately after CHECK directives
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 3 11:20:23 PDT 2020
probinson added a comment.
In D77227#1959983 <https://reviews.llvm.org/D77227#1959983>, @jdenny wrote:
> In D77227#1959936 <https://reviews.llvm.org/D77227#1959936>, @probinson wrote:
>
> > Grepping for `\bCHECK[A-Z0-9-]*\s+:` finds nothing in clang/test or llvm/test. Is "gotcha 2" a real thing we should worry about? If there are any cases like that, we'd catch them under the checks for "gotcha 1".
>
>
> You need a backslash before that `+`. It does match.
Well I'll be... Matches 46 lines in 10 files under llvm/test, none in clang/test. Worth looking for, then.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77227/new/
https://reviews.llvm.org/D77227
More information about the llvm-commits
mailing list