[PATCH] D77235: [NFC][PowerPC] Cleanup 64-bit and Darwin CalleeSavedRegs

Fri Apr 3 08:02:42 PDT 2020

sfertile added a comment.

I would rather we don't rename any of the ViaCopy lists, or `CSR_SRV464_TLS_PE_SaveList` since they are likely dead. We can write IR that triggers them, but Clang will only generate said IR for Darwin IIUC and from the name of the calling convention it is limited to C++. 
Also please clang format the changes.

================
Comment at: llvm/lib/Target/PowerPC/PPCCallingConv.td:328
-
 def CSR_SVR464   : CalleeSavedRegs<(add X14, X15, X16, X17, X18, X19, X20,
                                         X21, X22, X23, X24, X25, X26, X27, X28,
----------------
daltenty wrote:
> ZarkoCA wrote:
> > sfertile wrote:
> > > The `SVR4` is no longer appropriate, since this represent the CSRs for all the 64-bit targets, not just ELF. I think `CSR_64` is fine, but open to better suggestions.
> > I agree with Sean.  If we are going to use this for all 64BIT targets then we should name it appropriately. 
> > 
> > You may need to change the following tests when doing so: 
> > llvm/test/CodeGen/PowerPC/block-placement-1.mir
> > llvm/test/CodeGen/PowerPC/DisableHoistingDueToBlockHotnessProfileData.mir
> > llvm/test/CodeGen/PowerPC/aantidep-def-ec.mir
> > llvm/test/CodeGen/PowerPC/DisableHoistingDueToBlockHotnessNoProfileData.mir
> > llvm/test/CodeGen/PowerPC/machine-backward-cp.mir
> > llvm/test/CodeGen/PowerPC/licm-tocReg.ll
> > llvm/test/CodeGen/PowerPC/setcr_bc2.mir
> > llvm/test/CodeGen/PowerPC/setcr_bc.mir
> > llvm/test/CodeGen/PowerPC/setcr_bc3.mir
> > 
> CSR_64 is in use by X86, so to keep things clear I opted for CSR_PPC64
Works for me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77235/new/

https://reviews.llvm.org/D77235