[PATCH] D77235: [NFC][PowerPC] Cleanup 64-bit and Darwin CalleeSavedRegs

Thu Apr 2 12:28:44 PDT 2020

daltenty marked an inline comment as done.
daltenty added inline comments.

================
Comment at: llvm/lib/Target/PowerPC/PPCCallingConv.td:328
-
 def CSR_SVR464   : CalleeSavedRegs<(add X14, X15, X16, X17, X18, X19, X20,
                                         X21, X22, X23, X24, X25, X26, X27, X28,
----------------
ZarkoCA wrote:
> sfertile wrote:
> > The `SVR4` is no longer appropriate, since this represent the CSRs for all the 64-bit targets, not just ELF. I think `CSR_64` is fine, but open to better suggestions.
> I agree with Sean.  If we are going to use this for all 64BIT targets then we should name it appropriately. 
> 
> You may need to change the following tests when doing so: 
> llvm/test/CodeGen/PowerPC/block-placement-1.mir
> llvm/test/CodeGen/PowerPC/DisableHoistingDueToBlockHotnessProfileData.mir
> llvm/test/CodeGen/PowerPC/aantidep-def-ec.mir
> llvm/test/CodeGen/PowerPC/DisableHoistingDueToBlockHotnessNoProfileData.mir
> llvm/test/CodeGen/PowerPC/machine-backward-cp.mir
> llvm/test/CodeGen/PowerPC/licm-tocReg.ll
> llvm/test/CodeGen/PowerPC/setcr_bc2.mir
> llvm/test/CodeGen/PowerPC/setcr_bc.mir
> llvm/test/CodeGen/PowerPC/setcr_bc3.mir
> 
CSR_64 is in use by X86, so to keep things clear I opted for CSR_PPC64

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77235/new/

https://reviews.llvm.org/D77235