[PATCH] D76900: Enable IBT(Indirect Branch Tracking) in JIT with CET(Control-flow Enforcement Technology)

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm marked an inline comment as done.
xiangzhangllvm added inline comments.


================
Comment at: llvm/test/ExecutionEngine/MCJIT/cet-code-model-lager.ll:3
+target triple = "x86_64-unknown-linux-gnu"
+
+ at a = dso_local local_unnamed_addr global i32 1, align 4
----------------
LuoYuanke wrote:
> xiangzhangllvm wrote:
> > hjl.tools wrote:
> > > What does this test check?  Does it fail without the fix?
> > lli will call JIT to compile this code. This test is same with Eli's large code model test. 
> > This test will run fail if CET enabled JIT not generate endbr for the following 3 functions' entry in CET machine.
> lli can check CET even on machine without CET enabled?
lli can only check CET in CET enabled machine.

The llvm/test/CodeGen/X86/indirect-branch-tracking-cm-lager.ll test will staticly check the endbr in CET/nonCET machines.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76900/new/

https://reviews.llvm.org/D76900