[PATCH] D76900: Enable IBT(Indirect Branch Tracking) in JIT with CET(Control-flow Enforcement Technology)

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/test/ExecutionEngine/MCJIT/cet-code-model-lager.ll:1
+; RUN: %lli -code-model=large %s > /dev/null
+target triple = "x86_64-unknown-linux-gnu"
----------------
It seems the same test case to the previous one. Can we merge the 2 test case into one and use different run command?

; RUN: llc -mtriple=x86_64-unknown-unknown -code-model=large < %s | FileCheck %s
; RUN: %lli -code-model=large %s > /dev/null


================
Comment at: llvm/test/ExecutionEngine/MCJIT/cet-code-model-lager.ll:3
+target triple = "x86_64-unknown-linux-gnu"
+
+ at a = dso_local local_unnamed_addr global i32 1, align 4
----------------
xiangzhangllvm wrote:
> hjl.tools wrote:
> > What does this test check?  Does it fail without the fix?
> lli will call JIT to compile this code. This test is same with Eli's large code model test. 
> This test will run fail if CET enabled JIT not generate endbr for the following 3 functions' entry in CET machine.
lli can check CET even on machine without CET enabled?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76900/new/

https://reviews.llvm.org/D76900