[PATCH] D77227: [RFC][FileCheck] Require colon immediately after CHECK directives

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D77227#1958148 <https://reviews.llvm.org/D77227#1958148>, @probinson wrote:

> So, the population of genuine directives that don't follow the (whitespace or comment character) rule is extremely small, but not zero.


Thanks for the analysis.

> Do we try to find and fix them all, so that we can use the more restrictive rule?
>  Or do we fail to diagnose problems with directives that don't follow the rule, because that would introduce too many false positives?

Instead of ignoring well formed directives that don't follow the rule, maybe FileCheck should report them as errors.

FileCheck still couldn't diagnose *malformed* directives that don't follow the rule, but at least FileCheck would start discouraging people from thinking it's ok not to follow the rule.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77227/new/

https://reviews.llvm.org/D77227