[PATCH] D77227: [RFC][FileCheck] Require colon immediately after CHECK directives

Thu Apr 2 15:11:47 PDT 2020

jroelofs added a comment.

In D77227#1958013 <https://reviews.llvm.org/D77227#1958013>, @jroelofs wrote:

> In D77227#1957790 <https://reviews.llvm.org/D77227#1957790>, @jdenny wrote:
>
> > In D77227#1957707 <https://reviews.llvm.org/D77227#1957707>, @jroelofs wrote:
> >
> > > The diagnostic in this patch triggers 186 times in the suite of 36125 tests in llvm/test. Most of them are true positives, though there are ~45 false-positives that seem easy to work around by rewording the comments:
> >
> >
> > So 1/4 of positives are false positives?  Am I reading those numbers correctly?
>
>
> Yes, that's correct.

Probably a little higher, actually. I've been working through each positive individually, and have found a few things that should not have been broken. I suspect I've introduced a bug in `FindCheckType`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77227/new/

https://reviews.llvm.org/D77227