[PATCH] D68065: Propeller: LLD Support for Basic Block Sections

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/bb-sections-delete-fallthru.s:24
+
+# CHECK: <a.BB.foo>
+# CHECK-NEXT: nopl    (%rax)
----------------
MaskRay wrote:
> Add some spaces after `CHECK: ` to make the label aligned.
> 
> For subsequent `-NEXT:` lines, you can increase the indentation (say, by 1) to make it clear the instructions follow the label:
> 
> ```
> # CHECK:      <a.BB.foo>
> # CHECK-NEXT:  nopl (%rax)
> ```
> 
> Please fix other tests as well.
```
# CHECK:      <a.BB.foo>:
# CHECK-NEXT:  nopl (%rax)
```

Add a colon to make it clear that `a.BB.foo` is a label:


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68065/new/

https://reviews.llvm.org/D68065