[PATCH] D68065: Propeller: LLD Support for Basic Block Sections

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/bb-sections-delete-fallthru.s:8
+# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
+# RUN: ld.lld  -optimize-bb-jumps %t.o -o %t.out
+# RUN: llvm-objdump -d %t.out| FileCheck %s --check-prefix=CHECK
----------------
delete excess space and use `--optimize-bb-jumps`

I mentioned this in a previous comment.


================
Comment at: lld/test/ELF/bb-sections-delete-fallthru.s:24
+
+# CHECK: <a.BB.foo>
+# CHECK-NEXT: nopl    (%rax)
----------------
Add some spaces after `CHECK: ` to make the label aligned.

For subsequent `-NEXT:` lines, you can increase the indentation (say, by 1) to make it clear the instructions follow the label:

```
# CHECK:      <a.BB.foo>
# CHECK-NEXT:  nopl (%rax)
```

Please fix other tests as well.


================
Comment at: lld/test/ELF/bb-sections-delete-fallthru.s:26
+# CHECK-NEXT: nopl    (%rax)
+# CHECK-NEXT: je      {{[0-9]+}} <r.BB.foo>
+# CHECK-NOT: jmp
----------------
`je {{.*}} <r.BB.foo>` I have recently updated llvm-objdump -d to print the target address (to be consistent with GNU objdump ; is what most users desire) instead of a decimal PC relative immediate

No need to align the first operand.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68065/new/

https://reviews.llvm.org/D68065