[PATCH] D77245: [AMDGPU] Fix crash in SILoadStoreOptimizer

[David Stuttard via Phabricator via llvm-commits]

dstuttard added a comment.

My fix has been hanging around for a little while now - so my memory of it is a little hazy.

However, the issue I saw (and attempted to fix) was similar to yours. Agreed that I think this is a rare occurrence, so perhaps your approach makes more sense (and is simpler/cheaper).
One question - the reason I went with the solution I did was that a previous iteration of the loop doing the optimisation was invalidating the iterator stored in a later list - which caused a crash - is your fix working around this by avoiding creating those potentially dependent lists in the first place?? (I wasn't 100% sure about the logic).

I guess one potential advantage with my approach is that you still get the potential optimisations at the expense of having to re-compute the lists for dependent instructions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77245/new/

https://reviews.llvm.org/D77245