[PATCH] D77245: [AMDGPU] Fix crash in SILoadStoreOptimizer

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 2 08:06:27 PDT 2020


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM, but an additional MIR test wouldn't hurt



================
Comment at: llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:893
+      // basic block. This hint suggests that CI precedes Paired, which is
+      // true most of the times. However, moveInstsAfter() processing a
+      // previous list may have changed this order in a situation when it
----------------
s/times/time


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77245/new/

https://reviews.llvm.org/D77245





More information about the llvm-commits mailing list