[PATCH] D77300: [X86] Improve combineVectorShiftImm

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 2 07:33:44 PDT 2020


RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:40883
+      (!LogicalShift && ISD::isBuildVectorAllOnes(N0.getNode())))
     return N0;
 
----------------
ISD::isBuildVectorAll* leaves UNDEFs in there - we must generate the constant


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77300/new/

https://reviews.llvm.org/D77300





More information about the llvm-commits mailing list