[PATCH] D77227: [RFC][FileCheck] Require colon immediately after CHECK directives

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added subscribers: SjoerdMeijer, probinson.
jdenny added a comment.

Thanks for working on this.

  CHECK           gotcha 1

This case seems like it would trigger too many false positives.  Do you have numbers on how many true positives that this case alone catches and that are not caught by the other cases?

  CHECK :         gotcha 2

As long as only whitespace separates `CHECK` and `:`, this one seems ok.

  CHECK-SAME-DAG: gotcha 3
  CHECKNEXT:      gotcha 4
  CHECKDAG:       gotcha 5

These seem much less likely to trigger false positives.

@probinson and @SjoerdMeijer were also involved in previous discussions in this area and might want to take a look.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77227/new/

https://reviews.llvm.org/D77227