[PATCH] D77227: [RFC][FileCheck] Require colon immediately after CHECK directives

[Jonathan Roelofs via Phabricator via llvm-commits]

jroelofs added a comment.

Here's a sample of what I believe to be the true positives for this new diagnostic:

  llvm/test/tools/llvm-symbolizer/flag-grouping.test
  llvm/test/tools/llvm-readobj/COFF/codeview-linetables.test:107
  llvm/test/tools/llvm-objdump/ELF/ARM/v5te-subarch.s:8
  llvm/test/tools/llvm-objcopy/COFF/patch-debug-dir.test:20
  llvm/test/tools/llvm-dwarfdump/X86/verify_strings.s:88
  llvm/test/tools/llvm-dwarfdump/X86/statistics.ll:47
  llvm/test/tools/llvm-ar/replace-update.test:60
  llvm/test/tools/dsymutil/fat-binary-output.test:27
  llvm/test/tools/dsymutil/X86/modules.m:120
  llvm/test/tools/dsymutil/ARM/scattered.c:10
  llvm/test/Transforms/SimplifyCFG/pr33605.ll:30
  llvm/test/Transforms/SimplifyCFG/Hexagon/switch-to-lookup-table.ll
  llvm/test/Transforms/SampleProfile/gcc-simple.ll:132
  llvm/test/Transforms/PGOProfile/memop_clone.ll:13
  llvm/test/Transforms/PGOProfile/icp_invoke.ll:104
  llvm/test/Transforms/LoopVectorize/followup.ll:32
  llvm/test/Transforms/LoopVectorize/first-order-recurrence-complex.ll:132
  llvm/test/Transforms/LoopVectorize/debugloc.ll:20
  llvm/test/Transforms/LoopVectorize/ARM/prefer-tail-loop-folding.ll:203
  llvm/test/Transforms/LoopUnroll/runtime-loop5.ll:26
  llvm/test/Transforms/LoopUnroll/peel-loop-negative.ll:7
  llvm/test/Transforms/LoopUnroll/AArch64/falkor-prefetch.ll
  llvm/test/Transforms/LoopStrengthReduce/X86/lsr-insns-2.ll:13
  llvm/test/Transforms/LoopRotate/pr35210.ll:67
  llvm/test/Transforms/LoopInterchange/call-instructions.ll:30
  llvm/test/Transforms/LoopDeletion/use-in-unreachable.ll:9
  llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/merge-stores.ll:114
  llvm/test/Transforms/LoadStoreVectorizer/AMDGPU/vect-ptr-ptr-size-mismatch.ll:58
  llvm/test/Transforms/InstSimplify/compare.ll:281
  llvm/test/Transforms/InstCombine/str-int.ll:112
  llvm/test/Transforms/InstCombine/str-int-2.ll:111
  llvm/test/Transforms/InstCombine/phi-preserve-ir-flags.ll:20
  llvm/test/Transforms/InstCombine/intptr1.ll:30

These came from a range of about `6k` test files, putting failure rate of this class of bugs right around `0.53%`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77227/new/

https://reviews.llvm.org/D77227