[PATCH] D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D

[Digger via Phabricator via llvm-commits]

DiggerLin marked 4 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:799
+  if (Ret)
+        assert(getNumberOfAuxEntries() >=1 &&
+           "No CSECT Auxiliary Entry is found.");
----------------
jhenderson wrote:
> clang-format is still complaining here.
thanks


================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/disassemble-symbol-description.test:1
+; REQUIRES: powerpc-registered-target
+
----------------
jhenderson wrote:
> Use '#' for all lit directives, not just the RUN lines.
thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72973/new/

https://reviews.llvm.org/D72973