[PATCH] D72973: [llvm-objdump] Use symbol index+symbol name + storage mapping class as label for -D

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 1 00:31:01 PDT 2020


jhenderson added inline comments.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:799
+  if (Ret)
+        assert(getNumberOfAuxEntries() >=1 &&
+           "No CSECT Auxiliary Entry is found.");
----------------
clang-format is still complaining here.


================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/disassemble-symbol-description.test:1
+; REQUIRES: powerpc-registered-target
+
----------------
Use '#' for all lit directives, not just the RUN lines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72973/new/

https://reviews.llvm.org/D72973





More information about the llvm-commits mailing list