[PATCH] D77152: [SelectionDAG] Better legalization for FSHL and FSHR

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D77152#1952847 <https://reviews.llvm.org/D77152#1952847>, @foad wrote:

> This is a work in progress but I'd appreciate any feedback.
>
> - Does this seem like the right thing to do in general?


I think SelectionDAGBuilder expanding this is nonsense, so yes. The expansion is also duplicated in two places, which is also bad.

> - How should I implement integer expansion for funnel shifts?

This is already done?

> - Any advice on fixing any of the code quality regressions in the tests?




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77152/new/

https://reviews.llvm.org/D77152