[PATCH] D77111: Fix buildgo.sh script because of recent changes causing build failures with gcc on linux

[Dylan McKay via llvm-commits]

I think there are still a couple buildbot issues

Specifically from this part of ad1466f8cbc520b2f03e1f6daa78f035bccf21df

diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp
b/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp
index b5261409de9..23469953241 100644---
a/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp+++
b/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp
@@ -1861,6 +1861,105 @@ SignalContext::WriteFlag
SignalContext::GetWriteFlag() const {
 #endif
   u32 instr = *(u32 *)pc;
   return (instr >> 21) & 1 ? WRITE: READ;+#elif defined(__riscv)+
unsigned long pc = ucontext->uc_mcontext.__gregs[REG_PC];+  unsigned
faulty_instruction = *(uint16_t *)pc;++#if
defined(__riscv_compressed)+  if ((faulty_instruction & 0x3) != 0x3) {
 // it's a compressed instruction+    // set op_bits to the
instruction bits [1, 0, 15, 14, 13]+    unsigned op_bits =+
((faulty_instruction & 0x3) << 3) | (faulty_instruction >> 13);+
unsigned rd = faulty_instruction & 0xF80;  // bits 7-11, inclusive+
switch (op_bits) {+      case 0b10'010:  // c.lwsp (rd != x0)+#if
__riscv_xlen == 64+      case 0b10'011:  // c.ldsp (rd != x0)+#endif+
      return rd ? SignalContext::READ : SignalContext::UNKNOWN;+
case 0b00'010:  // c.lw+#if __riscv_flen >= 32 && __riscv_xlen == 32+
    case 0b10'011:  // c.flwsp+#endif+#if __riscv_flen >= 32 ||
__riscv_xlen == 64+      case 0b00'011:  // c.flw / c.ld+#endif+#if
__riscv_flen == 64+      case 0b00'001:  // c.fld+      case 0b10'001:
 // c.fldsp+#endif+        return SignalContext::READ;+      case
0b00'110:  // c.sw+      case 0b10'110:  // c.swsp+#if __riscv_flen >=
32 || __riscv_xlen == 64+      case 0b00'111:  // c.fsw / c.sd+
case 0b10'111:  // c.fswsp / c.sdsp

I get errors on the avr buildbot from the ‘ characters in the middle of the
integers. I haven’t seen this C++14 feature before, TIL. I’m running a
mostly standard buildbot configuration (a Dockerfile and a standard Clang
buildbot targeting AVR and X86), so I suspect this may affect other
buildbots too. Perhaps there is a missing ‘-std=c++14’ in the go scripts?

Here’s an example of the failure:
http://lab.llvm.org:8014/builders/llvm-avr-linux/builds/5966/steps/ninja%20check%201/logs/stdio

Cheers,
Dylan

On Tue, Mar 31, 2020 at 9:04 PM Dmitry Vyukov via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:

> dvyukov accepted this revision.
> dvyukov added a comment.
> This revision is now accepted and ready to land.
>
> Thanks!
>
>
> Repository:
>   rCRT Compiler Runtime
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D77111/new/
>
> https://reviews.llvm.org/D77111
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200401/972adff2/attachment-0001.html>