<div dir="ltr"><div class="markdown-here-wrapper" style=""><p style="margin:0px 0px 1.2em!important">I think there are still a couple buildbot issues</p>
<p style="margin:0px 0px 1.2em!important">Specifically from this part of ad1466f8cbc520b2f03e1f6daa78f035bccf21df</p>
<pre style="font-size:0.85em;font-family:Consolas,Inconsolata,Courier,monospace;font-size:1em;line-height:1.2em;margin:1.2em 0px"><code class="hljs language-patch" style="font-size:0.85em;font-family:Consolas,Inconsolata,Courier,monospace;margin:0px 0.15em;padding:0px 0.3em;white-space:pre-wrap;border:1px solid rgb(234,234,234);background-color:rgb(248,248,248);border-radius:3px;display:inline;white-space:pre;overflow:auto;border-radius:3px;border:1px solid rgb(204,204,204);padding:0.5em 0.7em;display:block!important;display:block;overflow-x:auto;padding:0.5em;color:rgb(51,51,51);background:rgb(248,248,248) none repeat scroll 0% 0%">diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp
index b5261409de9..23469953241 100644
<span class="hljs-header">--- a/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp</span>
<span class="hljs-header">+++ b/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp</span>
@@ -1861,6 +1861,105 @@ SignalContext::WriteFlag SignalContext::GetWriteFlag() const {
 #endif
   u32 instr = *(u32 *)pc;
   return (instr >> 21) & 1 ? WRITE: READ;
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+#elif defined(__riscv)</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+  unsigned long pc = ucontext->uc_mcontext.__gregs[REG_PC];</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+  unsigned faulty_instruction = *(uint16_t *)pc;</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+#if defined(__riscv_compressed)</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+  if ((faulty_instruction & 0x3) != 0x3) {  // it's a compressed instruction</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+    // set op_bits to the instruction bits [1, 0, 15, 14, 13]</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+    unsigned op_bits =</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+        ((faulty_instruction & 0x3) << 3) | (faulty_instruction >> 13);</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+    unsigned rd = faulty_instruction & 0xF80;  // bits 7-11, inclusive</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+    switch (op_bits) {</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+      case 0b10'010:  // c.lwsp (rd != x0)</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+#if __riscv_xlen == 64</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+      case 0b10'011:  // c.ldsp (rd != x0)</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+#endif</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+        return rd ? SignalContext::READ : SignalContext::UNKNOWN;</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+      case 0b00'010:  // c.lw</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+#if __riscv_flen >= 32 && __riscv_xlen == 32</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+      case 0b10'011:  // c.flwsp</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+#endif</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+#if __riscv_flen >= 32 || __riscv_xlen == 64</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+      case 0b00'011:  // c.flw / c.ld</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+#endif</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+#if __riscv_flen == 64</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+      case 0b00'001:  // c.fld</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+      case 0b10'001:  // c.fldsp</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+#endif</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+        return SignalContext::READ;</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+      case 0b00'110:  // c.sw</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+      case 0b10'110:  // c.swsp</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+#if __riscv_flen >= 32 || __riscv_xlen == 64</span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+      case 0b00'111:  // c.fsw / <a href="http://c.sd">c.sd</a></span>
<span class="hljs-addition" style="background:rgb(221,255,221) none repeat scroll 0% 0%">+      case 0b10'111:  // c.fswsp / c.sdsp</span>
</code></pre>
<p style="margin:0px 0px 1.2em!important">I get errors on the avr buildbot from the ‘ characters in the middle of the integers. I haven’t seen this C++14 feature before, TIL. I’m running a mostly standard buildbot configuration (a Dockerfile and a standard Clang buildbot targeting AVR and X86), so I suspect this may affect other buildbots too. Perhaps there is a missing ‘-std=c++14’ in the go scripts?</p>
<p style="margin:0px 0px 1.2em!important">Here’s an example of the failure: <a href="http://lab.llvm.org:8014/builders/llvm-avr-linux/builds/5966/steps/ninja%20check%201/logs/stdio">http://lab.llvm.org:8014/builders/llvm-avr-linux/builds/5966/steps/ninja%20check%201/logs/stdio</a></p>
<p style="margin:0px 0px 1.2em!important">Cheers,<br>Dylan</p>
<div title="MDH:PGRpdj5JIHRoaW5rIHRoZXJlIGFyZSBzdGlsbCBhIGNvdXBsZSBidWlsZGJvdCBpc3N1ZXM8L2Rp
dj48ZGl2Pjxicj48L2Rpdj48ZGl2PlNwZWNpZmljYWxseSBmcm9tIHRoaXMgcGFydCBvZiBhZDE0
NjZmOGNiYzUyMGIyZjAzZTFmNmRhYTc4ZjAzNWJjY2YyMWRmPC9kaXY+PGRpdj48YnI+PC9kaXY+
PGRpdj5gYGBwYXRjaDxicj48L2Rpdj48ZGl2PmRpZmYgLS1naXQgYS9jb21waWxlci1ydC9saWIv
c2FuaXRpemVyX2NvbW1vbi9zYW5pdGl6ZXJfbGludXguY3BwIGIvY29tcGlsZXItcnQvbGliL3Nh
bml0aXplcl9jb21tb24vc2FuaXRpemVyX2xpbnV4LmNwcDxicj5pbmRleCBiNTI2MTQwOWRlOS4u
MjM0Njk5NTMyNDEgMTAwNjQ0PGJyPi0tLSBhL2NvbXBpbGVyLXJ0L2xpYi9zYW5pdGl6ZXJfY29t
bW9uL3Nhbml0aXplcl9saW51eC5jcHA8YnI+KysrIGIvY29tcGlsZXItcnQvbGliL3Nhbml0aXpl
cl9jb21tb24vc2FuaXRpemVyX2xpbnV4LmNwcDxicj5AQCAtMTg2MSw2ICsxODYxLDEwNSBAQCBT
aWduYWxDb250ZXh0OjpXcml0ZUZsYWcgU2lnbmFsQ29udGV4dDo6R2V0V3JpdGVGbGFnKCkgY29u
c3Qgezxicj4mbmJzcDsjZW5kaWY8YnI+Jm5ic3A7ICZuYnNwO3UzMiA8c3BhbiB6ZXVtNGMxPSJQ
Ul8xXzAiIGRhdGEtZGRud2FiPSJQUl8xXzAiIGFyaWEtaW52YWxpZD0iZ3JhbW1hciIgY2xhc3M9
IkxtIG5nIj5pbnN0cjwvc3Bhbj4gPSAqKHUzMiAqKXBjOzxicj4mbmJzcDsgJm5ic3A7cmV0dXJu
ICg8c3BhbiB6ZXVtNGMxPSJQUl8yXzAiIGRhdGEtZGRud2FiPSJQUl8yXzAiIGFyaWEtaW52YWxp
ZD0iZ3JhbW1hciIgY2xhc3M9IkxtIG5nIj5pbnN0cjwvc3Bhbj4gJmd0OyZndDsgMjEpICZhbXA7
IDEgPyBXUklURTogUkVBRDs8YnI+KyNlbGlmIGRlZmluZWQoX19yaXNjdik8YnI+KyAmbmJzcDt1
bnNpZ25lZCBsb25nIHBjID0gdWNvbnRleHQtJmd0O3VjX21jb250ZXh0Ll9fZ3JlZ3NbUkVHX1BD
XTs8YnI+KyAmbmJzcDt1bnNpZ25lZCBmYXVsdHlfaW5zdHJ1Y3Rpb24gPSAqKHVpbnQxNl90ICop
cGM7PGJyPis8YnI+KyNpZiBkZWZpbmVkKF9fcmlzY3ZfY29tcHJlc3NlZCk8YnI+KyAmbmJzcDtp
ZiAoKGZhdWx0eV9pbnN0cnVjdGlvbiAmYW1wOyAweDMpICE9IDB4MykgeyAmbmJzcDsvLyBpdCdz
IGEgY29tcHJlc3NlZCBpbnN0cnVjdGlvbjxicj4rICZuYnNwOyAmbmJzcDsvLyBzZXQgb3BfYml0
cyB0byB0aGUgaW5zdHJ1Y3Rpb24gYml0cyBbMSwgMCwgMTUsIDE0LCAxM108YnI+KyAmbmJzcDsg
Jm5ic3A7dW5zaWduZWQgb3BfYml0cyA9PGJyPisgJm5ic3A7ICZuYnNwOyAmbmJzcDsgJm5ic3A7
KChmYXVsdHlfaW5zdHJ1Y3Rpb24gJmFtcDsgMHgzKSAmbHQ7Jmx0OyAzKSB8IChmYXVsdHlfaW5z
dHJ1Y3Rpb24gJmd0OyZndDsgMTMpOzxicj4rICZuYnNwOyAmbmJzcDt1bnNpZ25lZCByZCA9IGZh
dWx0eV9pbnN0cnVjdGlvbiAmYW1wOyAweEY4MDsgJm5ic3A7Ly8gYml0cyA3LTExLCBpbmNsdXNp
dmU8YnI+KyAmbmJzcDsgJm5ic3A7c3dpdGNoIChvcF9iaXRzKSB7PGJyPisgJm5ic3A7ICZuYnNw
OyAmbmJzcDtjYXNlIDBiMTAnMDEwOiAmbmJzcDsvLyBjLmx3c3AgKHJkICE9IHgwKTxicj4rI2lm
IF9fcmlzY3ZfeGxlbiA9PSA2NDxicj4rICZuYnNwOyAmbmJzcDsgJm5ic3A7Y2FzZSAwYjEwJzAx
MTogJm5ic3A7Ly8gYy5sZHNwIChyZCAhPSB4MCk8YnI+KyNlbmRpZjxicj4rICZuYnNwOyAmbmJz
cDsgJm5ic3A7ICZuYnNwO3JldHVybiByZCA/IFNpZ25hbENvbnRleHQ6OlJFQUQgOiBTaWduYWxD
b250ZXh0OjpVTktOT1dOOzxicj4rICZuYnNwOyAmbmJzcDsgJm5ic3A7Y2FzZSAwYjAwJzAxMDog
Jm5ic3A7Ly8gYy5sdzxicj4rI2lmIF9fcmlzY3ZfZmxlbiAmZ3Q7PSAzMiAmYW1wOyZhbXA7IF9f
cmlzY3ZfeGxlbiA9PSAzMjxicj4rICZuYnNwOyAmbmJzcDsgJm5ic3A7Y2FzZSAwYjEwJzAxMTog
Jm5ic3A7Ly8gYy5mbHdzcDxicj4rI2VuZGlmPGJyPisjaWYgX19yaXNjdl9mbGVuICZndDs9IDMy
IHx8IF9fcmlzY3ZfeGxlbiA9PSA2NDxicj4rICZuYnNwOyAmbmJzcDsgJm5ic3A7Y2FzZSAwYjAw
JzAxMTogJm5ic3A7Ly8gYy5mbHcgLyBjLmxkPGJyPisjZW5kaWY8YnI+KyNpZiBfX3Jpc2N2X2Zs
ZW4gPT0gNjQ8YnI+KyAmbmJzcDsgJm5ic3A7ICZuYnNwO2Nhc2UgMGIwMCcwMDE6ICZuYnNwOy8v
IGMuZmxkPGJyPisgJm5ic3A7ICZuYnNwOyAmbmJzcDtjYXNlIDBiMTAnMDAxOiAmbmJzcDsvLyBj
LmZsZHNwPGJyPisjZW5kaWY8YnI+KyAmbmJzcDsgJm5ic3A7ICZuYnNwOyAmbmJzcDtyZXR1cm4g
U2lnbmFsQ29udGV4dDo6UkVBRDs8YnI+KyAmbmJzcDsgJm5ic3A7ICZuYnNwO2Nhc2UgMGIwMCcx
MTA6ICZuYnNwOy8vIGMuc3c8YnI+KyAmbmJzcDsgJm5ic3A7ICZuYnNwO2Nhc2UgMGIxMCcxMTA6
ICZuYnNwOy8vIGMuc3dzcDxicj4rI2lmIF9fcmlzY3ZfZmxlbiAmZ3Q7PSAzMiB8fCBfX3Jpc2N2
X3hsZW4gPT0gNjQ8YnI+KyAmbmJzcDsgJm5ic3A7ICZuYnNwO2Nhc2UgMGIwMCcxMTE6ICZuYnNw
Oy8vIGMuZnN3IC8gYy5zZDxicj4rICZuYnNwOyAmbmJzcDsgJm5ic3A7Y2FzZSAwYjEwJzExMTog
Jm5ic3A7Ly8gYy5mc3dzcCAvIGMuc2RzcDwvZGl2PjxkaXY+YGBgPC9kaXY+PGRpdj48YnI+PC9k
aXY+PGRpdj5JIGdldCBlcnJvcnMgb24gdGhlIGF2ciBidWlsZGJvdCBmcm9tIHRoZSAnIGNoYXJh
Y3RlcnMgaW4gdGhlIG1pZGRsZSBvZiB0aGUgaW50ZWdlcnMuIEkgaGF2ZW4ndCBzZWVuIHRoaXMg
QysrMTQgZmVhdHVyZSBiZWZvcmUsIFRJTC4gSSdtIHJ1bm5pbmcgYSBtb3N0bHkgc3RhbmRhcmQg
YnVpbGRib3QgY29uZmlndXJhdGlvbiAoYSBEb2NrZXJmaWxlIGFuZCBhIHN0YW5kYXJkIENsYW5n
IGJ1aWxkYm90IHRhcmdldGluZyBBVlIgYW5kIFg4NiksIHNvIEkgc3VzcGVjdCB0aGlzIG1heSBh
ZmZlY3Qgb3RoZXIgYnVpbGRib3RzIHRvby4gUGVyaGFwcyB0aGVyZSBpcyBhIG1pc3NpbmcgJy1z
dGQ9YysrMTQnIGluIHRoZSBnbyBzY3JpcHRzPzwvZGl2PjxkaXY+PGJyPjwvZGl2PjxkaXY+SGVy
ZSdzIGFuIGV4YW1wbGUgb2YgdGhlIGZhaWx1cmU6IGh0dHA6Ly9sYWIubGx2bS5vcmc6ODAxNC9i
dWlsZGVycy9sbHZtLWF2ci1saW51eC9idWlsZHMvNTk2Ni9zdGVwcy9uaW5qYSUyMGNoZWNrJTIw
MS9sb2dzL3N0ZGlvPC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdj5DaGVlcnMsPC9kaXY+PGRpdj5E
eWxhbjxicj48L2Rpdj4=" style="height:0;width:0;max-height:0;max-width:0;overflow:hidden;font-size:0em;padding:0;margin:0"></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Mar 31, 2020 at 9:04 PM Dmitry Vyukov via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">dvyukov accepted this revision.<br>
dvyukov added a comment.<br>
This revision is now accepted and ready to land.<br>
<br>
Thanks!<br>
<br>
<br>
Repository:<br>
  rCRT Compiler Runtime<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D77111/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D77111/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D77111" rel="noreferrer" target="_blank">https://reviews.llvm.org/D77111</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>