[PATCH] D77126: Add a method to build affine maps with zero or more results.

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula accepted this revision.
bondhugula added a comment.

Thanks for fixing this. In fact, I had review comments along the lines you address on an earlier patch that introduced these but looks like they didn't get in. (For consistency, we do need the ability to create 0 result maps that have an arbitrary number of dimensions and symbols, which your patch addresses.)



================
Comment at: mlir/include/mlir/IR/AffineMap.h:52
 
+  // Returns an affine map with `dimCount` dimensions and `symbolCount` mapping
+  // to the given results. The array of results cannot be empty.
----------------
Doc comment ///
`symbolCount` -> `symbolCount` symbols


================
Comment at: mlir/include/mlir/IR/AffineMap.h:57
 
+  // Returns an affine map with `dimCount` dimensions and `symbolCount` mapping
+  // to the given results. The array of results can be empty.
----------------
Doc comment ///

Nit: -> 'to the given results, where the number of results can be zero.'


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77126/new/

https://reviews.llvm.org/D77126