[PATCH] D77126: Add a method to build affine maps with zero or more results.

[Alex Zinenko via Phabricator via llvm-commits]

ftynse accepted this revision.
ftynse marked an inline comment as done.
ftynse added inline comments.


================
Comment at: mlir/include/mlir/IR/AffineMap.h:52
 
+  // Returns an affine map with `dimCount` dimensions and `symbolCount` mapping
+  // to the given results. The array of results cannot be empty.
----------------
bondhugula wrote:
> Doc comment ///
> `symbolCount` -> `symbolCount` symbols
Nit: please use `///` for documenting public methods


================
Comment at: mlir/lib/IR/MLIRContext.cpp:616
                          MLIRContext *context) {
-  return getImpl(dimCount, /*symbolCount=*/0, /*results=*/{}, context);
+  return getImpl(dimCount, symbolCount, /*results=*/{}, context);
 }
----------------
ouch...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77126/new/

https://reviews.llvm.org/D77126