[PATCH] D77118: [PowerPC] Ignore implicit register operands for MCInst

[Qing Shan Zhang via Phabricator via llvm-commits]

steven.zhang added a comment.

I think this is a good catch. InstAlias match the MI strictly including the implicit operands. We can either try to loose that check or remove the implicit operand when lowering the MI to MCInst, as it is not needed anymore.  And please test this patch completely as  this patch expose much more alias opportunities that didn't test before.



================
Comment at: llvm/test/CodeGen/PowerPC/atomics-regression.ll:1234
 ; PPC64LE-NEXT:    sync
-; PPC64LE-NEXT:  .LBB79_1:
+; PPC64LE-NEXT:  .LBB79_1: #
 ; PPC64LE-NEXT:    ldarx 6, 0, 3
----------------
Could you please explain more on the extra "#" here ?


================
Comment at: llvm/test/CodeGen/PowerPC/xray-conditional-return.ll:42
 ; CHECK-LABEL: @Foo2
-; CHECK:   cmpw [[CR:[0-9]+]]
-; CHECK-NEXT:   bge [[CR]], [[LABEL:\.[a-zA-Z0-9]+]]
+; CHECK:   cmpw
+; CHECK-NEXT:   bge 0, [[LABEL:\.[a-zA-Z0-9]+]]
----------------
I don't see this change relative with alias.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77118/new/

https://reviews.llvm.org/D77118