[PATCH] D77095: [mlir] Change the default of `mlir-print-op-on-diagnostic` to true

[River Riddle via Phabricator via llvm-commits]

rriddle marked 2 inline comments as done.
rriddle added inline comments.


================
Comment at: mlir/lib/IR/MLIRContext.cpp:55
+                   "as an attached note"));
+
 /// A utility function to safely get or create a uniqued instance within the
----------------
mehdi_amini wrote:
> Can we avoid cl::opt here and push it to clients? (trying to avoid more global constructor / global state)
This is the same situation that we are already in. Moving to clients will require more churn on a currently simple revision. I'd rather defer that for a followup.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77095/new/

https://reviews.llvm.org/D77095