[PATCH] D77095: [mlir] Change the default of `mlir-print-op-on-diagnostic` to true

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 30 15:17:12 PDT 2020


mehdi_amini added inline comments.


================
Comment at: mlir/lib/IR/MLIRContext.cpp:55
+                   "as an attached note"));
+
 /// A utility function to safely get or create a uniqued instance within the
----------------
Can we avoid cl::opt here and push it to clients? (trying to avoid more global constructor / global state)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77095/new/

https://reviews.llvm.org/D77095





More information about the llvm-commits mailing list