[PATCH] D77060: [MLIR] Make OpBuilder(Block) default to inserting at Block::begin().

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 30 13:04:34 PDT 2020

Previous message: [PATCH] D77060: [MLIR] Make OpBuilder(Block) default to inserting at Block::begin().
Next message: [PATCH] D77060: [MLIR] Replace OpBuilder(Block) with AtBlockBegin and AtBlockEnd
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

rriddle added a comment.

I'm +1 on the explicit factory methods


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77060/new/

https://reviews.llvm.org/D77060

Previous message: [PATCH] D77060: [MLIR] Make OpBuilder(Block) default to inserting at Block::begin().
Next message: [PATCH] D77060: [MLIR] Replace OpBuilder(Block) with AtBlockBegin and AtBlockEnd
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list