[PATCH] D77060: [MLIR] Make OpBuilder(Block) default to inserting at Block::begin().

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 30 12:30:26 PDT 2020


mehdi_amini added a comment.
Herald added a subscriber: grosul1.

I prefer the explicit version as well.
In the past I tried to change `OpBuilder(Operation *)` in a similar way by forcing an enum:  `OpBuilder builder(op, OpBuilder::After)` / `OpBuilder builder(op, OpBuilder::Before)`, but a factory method is good as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77060/new/

https://reviews.llvm.org/D77060





More information about the llvm-commits mailing list