[PATCH] D77072: [mlir] LLVMFuncOp: provide a capability to pass attributes through to LLVM IR

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache added inline comments.


================
Comment at: mlir/docs/Dialects/LLVM.md:107
+attribute.
+
 ### LLVM IR operations
----------------
mehdi_amini wrote:
> That seems a bit like a hack to me: when importing from LLVM are we gonna encode attributes this way? Are we gonna honor them?
> We're getting into the "json of compiler" here.
> 
Isn't the LLVM `string = string` attribute the issue here?
Would an alternative require giving more semantics than LLVM has?

In other words, until/unless LLVM force more semantics on those attributes, isn't it a raising problem to import from LLVM and guesstimate types? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77072/new/

https://reviews.llvm.org/D77072