[PATCH] D77072: [mlir] LLVMFuncOp: provide a capability to pass attributes through to LLVM IR

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 30 11:24:24 PDT 2020


mehdi_amini added inline comments.


================
Comment at: mlir/docs/Dialects/LLVM.md:107
+attribute.
+
 ### LLVM IR operations
----------------
That seems a bit like a hack to me: when importing from LLVM are we gonna encode attributes this way? Are we gonna honor them?
We're getting into the "json of compiler" here.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77072/new/

https://reviews.llvm.org/D77072





More information about the llvm-commits mailing list